[Pending Documentation] 931 Connection Security for Network Component #938
+54
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabeblis
requested changes
Nov 26, 2024
...lidations/constraints/content/ssp-network-component-has-connection-security-prop-INVALID.xml
Show resolved
Hide resolved
...lidations/constraints/content/ssp-network-component-has-connection-security-prop-INVALID.xml
Show resolved
Hide resolved
14 tasks
Gabeblis
requested changes
Nov 27, 2024
… work because I am still figuring out oscal syntax
kyhu65867
force-pushed
the
931-connection-security
branch
from
6625c35
to
9bcc47b
Compare
wandmagic
approved these changes
Nov 27, 2024
DimitriZhurkin
requested changes
Nov 27, 2024
DimitriZhurkin
approved these changes
Nov 27, 2024
Gabeblis
approved these changes
Nov 29, 2024
Gabeblis
changed the title
aj-stein-gsa
requested changes
Nov 29, 2024
| </expect> | ||
| <expect id="network-component-has-connection-security-prop" target="//component[(@type='service' and not(./prop[@name='leveraged-authorization-uuid']) and ./prop[@name='implementation-point' and @value='external']) or (@type='interconnection') or (@type='service' and ./prop[@name='implementation-point' and @value='internal'] and ./prop[@name='direction']) or (@type='software' and ./prop[@name='asset-type' and @value='cli'] and ./prop[@name='direction'])]" test="count(./prop[@name='interconnection-security' and @ns='https://fedramp.gov/ns/oscal']) >= 1" level="ERROR"> | ||
| <formal-name>Network Component Has Connection Security Property</formal-name> | ||
| <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/5-attachments/#system-inventory-approach"/> |
There was a problem hiding this comment.
I would adjust the PR accordingly for the updated doc PR I added to wrap this work up.
Suggested change
| <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/5-attachments/#system-inventory-approach"/> | |
| <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/4-ssp-template-to-oscal-mapping/#ports-protocols-and-services"/> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… work because I am still figuring out oscal syntax
Committer Notes
This is a draft. I may need some help tomorrow figuring out if there is a connection security property or if it should be "interconnection security"
Addresses issue #931
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.